Re: [PATCH v2 09/13] drm/gem: Add LRU/shrinker helper

2022-07-20 Thread Rob Clark
On Tue, Jul 19, 2022 at 11:56 AM Dmitry Osipenko wrote: > > On 7/19/22 20:18, Rob Clark wrote: > > +void > > +drm_gem_lru_move_tail_locked(struct drm_gem_lru *lru, struct > > drm_gem_object *obj) > > +{ > > + WARN_ON(!mutex_is_locked(lru->lock)); > > Nit: What about lockdep_assert_held_once(&

Re: [PATCH v2 09/13] drm/gem: Add LRU/shrinker helper

2022-07-19 Thread Dmitry Osipenko
On 7/19/22 20:18, Rob Clark wrote: > +void > +drm_gem_lru_move_tail_locked(struct drm_gem_lru *lru, struct drm_gem_object > *obj) > +{ > + WARN_ON(!mutex_is_locked(lru->lock)); Nit: What about lockdep_assert_held_once(&lru->lock->base)) ? Otherwise, looks good! I'll use it for the DRM-SHMEM

[PATCH v2 09/13] drm/gem: Add LRU/shrinker helper

2022-07-19 Thread Rob Clark
From: Rob Clark Add a simple LRU helper to assist with driver's shrinker implementation. It handles tracking the number of backing pages associated with a given LRU, and provides a helper to implement shrinker_scan. A driver can use multiple LRU instances to track objects in various states, for