Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-27 Thread Lee Jones
[...] > > > > > +#define MT6370_IRQ_DSV_VPOS_OCP 124 > > > > > +#define MT6370_IRQ_DSV_BST_OCP 125 > > > > > +#define MT6370_IRQ_DSV_VNEG_SCP 126 > > > > > +#define MT6370_IRQ_DSV_VPOS_SCP 127 > > > > > + > > > > > +struct mt6370_info { > > > >

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-27 Thread ChiaEn Wu
Hi Lee, Thanks for your reply! Lee Jones 於 2022年6月27日 週一 晚上10:14寫道: > > On Sat, 18 Jun 2022, ChiaEn Wu wrote: > > > Hi Lee, > > > > Thanks for your helpful comments, we have some questions and replies below. > > > > Lee Jones 於 2022年6月16日 週四 清晨6:49寫道: > > > > > > > > On Mon, 13 Jun 2022, ChiaEn

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-27 Thread Lee Jones
On Sat, 18 Jun 2022, ChiaEn Wu wrote: > Hi Lee, > > Thanks for your helpful comments, we have some questions and replies below. > > Lee Jones 於 2022年6月16日 週四 清晨6:49寫道: > > > > > On Mon, 13 Jun 2022, ChiaEn Wu wrote: > > > > > From: ChiYuan Huang > > > > > > Add Mediatek MT6370 MFD support. >

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-18 Thread Jonathan Cameron
On Mon, 13 Jun 2022 19:11:39 +0800 ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek MT6370 MFD support. > > Signed-off-by: ChiYuan Huang Hi. A few trivial things that probably overlap with other reviewer comments. > +static int mt6370_check_vendor_info(struct mt6370_info *info) > +{

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-17 Thread ChiaEn Wu
Hi Lee, Thanks for your helpful comments, we have some questions and replies below. Lee Jones 於 2022年6月16日 週四 清晨6:49寫道: > > On Mon, 13 Jun 2022, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > Add Mediatek MT6370 MFD support. > > > > Signed-off-by: ChiYuan Huang > > --- > > drivers/mfd/Kc

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-15 Thread Lee Jones
On Mon, 13 Jun 2022, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek MT6370 MFD support. > > Signed-off-by: ChiYuan Huang > --- > drivers/mfd/Kconfig | 13 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/mt6370.c | 349 +++ > 3 files changed,

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-13 Thread Randy Dunlap
On 6/13/22 04:11, ChiaEn Wu wrote: > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3b59456f5545..d9a7524a3e0e 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -937,6 +937,19 @@ config MFD_MT6360 > PMIC part includes 2-channel BUCKs and 2-channel LDOs >

[PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-13 Thread ChiaEn Wu
From: ChiYuan Huang Add Mediatek MT6370 MFD support. Signed-off-by: ChiYuan Huang --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 349 +++ 3 files changed, 363 insertions(+) create mode 100644 drivers/mfd/mt6370.c