Re: [PATCH v2 08/14] mm/khugepaged: Remove redundant pmd_devmap() check

2025-06-19 Thread Alistair Popple
On Tue, Jun 17, 2025 at 11:44:30AM +0200, David Hildenbrand wrote: > On 16.06.25 13:58, Alistair Popple wrote: > > The only users of pmd_devmap were device dax and fs dax. The check for > > pmd_devmap() in check_pmd_state() is therefore redundant as callers > > explicitly check for is_zone_device_p

Re: [PATCH v2 08/14] mm/khugepaged: Remove redundant pmd_devmap() check

2025-06-17 Thread David Hildenbrand
On 16.06.25 13:58, Alistair Popple wrote: The only users of pmd_devmap were device dax and fs dax. The check for pmd_devmap() in check_pmd_state() is therefore redundant as callers explicitly check for is_zone_device_page(), so this check can be dropped. Looking again, is this true? If we ret

[PATCH v2 08/14] mm/khugepaged: Remove redundant pmd_devmap() check

2025-06-16 Thread Alistair Popple
The only users of pmd_devmap were device dax and fs dax. The check for pmd_devmap() in check_pmd_state() is therefore redundant as callers explicitly check for is_zone_device_page(), so this check can be dropped. Signed-off-by: Alistair Popple Acked-by: David Hildenbrand Reviewed-by: Jason Gunth