[PATCH v2 07/10] drm/nouveau/graph: pad firmware code at load time

2014-04-22 Thread Alexandre Courbot
On 04/22/2014 08:48 AM, Ben Skeggs wrote: > On Tue, Apr 22, 2014 at 4:03 AM, Ilia Mirkin wrote: >> On Mon, Apr 21, 2014 at 2:02 AM, Alexandre Courbot >> wrote: >>> Pad the microcode to a multiple of 0x40 bytes, otherwise firmware will >> >> bytes or u32's? From the code, I'm guessing the latter.

[PATCH v2 07/10] drm/nouveau/graph: pad firmware code at load time

2014-04-22 Thread Ben Skeggs
On Tue, Apr 22, 2014 at 4:03 AM, Ilia Mirkin wrote: > On Mon, Apr 21, 2014 at 2:02 AM, Alexandre Courbot > wrote: >> Pad the microcode to a multiple of 0x40 bytes, otherwise firmware will > > bytes or u32's? From the code, I'm guessing the latter. (Similar > concern about comment in the code.) >

[PATCH v2 07/10] drm/nouveau/graph: pad firmware code at load time

2014-04-21 Thread Alexandre Courbot
Pad the microcode to a multiple of 0x40 bytes, otherwise firmware will fail to run from non-prepadded firmware files. Signed-off-by: Alexandre Courbot Reviewed-by: Thierry Reding --- drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH v2 07/10] drm/nouveau/graph: pad firmware code at load time

2014-04-21 Thread Ilia Mirkin
On Mon, Apr 21, 2014 at 2:02 AM, Alexandre Courbot wrote: > Pad the microcode to a multiple of 0x40 bytes, otherwise firmware will bytes or u32's? From the code, I'm guessing the latter. (Similar concern about comment in the code.) > fail to run from non-prepadded firmware files. > > Signed-off