[PATCH v2 07/10] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-09 Thread Damien Lespiau
On Thu, Jun 04, 2015 at 07:12:38PM +0530, Kausal Malladi wrote: > From: Kausal Malladi > > This patch does the following: > 1. Adds the core function to program Gamma correction values for CHV/BSW >platform A couple of things I forgot (they are probably others): - This patch doesn't actual

[PATCH v2 07/10] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-09 Thread Damien Lespiau
(Note I haven't actually looked at the CHV specific details just yet, that'll be for another pass). On Thu, Jun 04, 2015 at 07:12:38PM +0530, Kausal Malladi wrote: > +int chv_set_gamma(struct drm_device *dev, uint32_t blob_id, > + struct drm_crtc *crtc) > +{ > + struct drm_gamma *g

[PATCH v2 07/10] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-09 Thread Damien Lespiau
On Sat, Jun 06, 2015 at 05:39:23PM +0530, Sharma, Shashank wrote: > >>+if (gamma_data->gamma_precision == I915_GAMMA_PRECISION_UNKNOWN) { > >Switch/case instead? > Yep, got it. > > > >Also, is UNKNOWN for disabling? Why not rename it to DISABLE then? > Actually unknown is valid in case of get_p

[PATCH v2 07/10] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-06 Thread Sharma, Shashank
Regards Shashank On 6/6/2015 11:03 AM, Jindal, Sonika wrote: > > > On 6/4/2015 7:12 PM, Kausal Malladi wrote: >> From: Kausal Malladi >> >> This patch does the following: >> 1. Adds the core function to program Gamma correction values for CHV/BSW >> platform >> 2. Adds Gamma correction macros

[PATCH v2 07/10] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-06 Thread Jindal, Sonika
On 6/4/2015 7:12 PM, Kausal Malladi wrote: > From: Kausal Malladi > > This patch does the following: > 1. Adds the core function to program Gamma correction values for CHV/BSW > platform > 2. Adds Gamma correction macros/defines > 3. Adds drm_mode_crtc_update_color_property function, which r