Re: [PATCH v2 06/27] gpu: host1x: Cleanup includes

2013-10-08 Thread Thierry Reding
On Tue, Oct 08, 2013 at 08:59:58AM +0300, Terje Bergström wrote: > On 07.10.2013 11:34, Thierry Reding wrote: > > Most of the included files are either not required or already included > > by some other header file. > > What's the general policy? I personally feel that each source file > should #i

Re: [PATCH v2 06/27] gpu: host1x: Cleanup includes

2013-10-07 Thread Terje Bergström
On 07.10.2013 11:34, Thierry Reding wrote: > Most of the included files are either not required or already included > by some other header file. What's the general policy? I personally feel that each source file should #include all the header files it needs, and should not rely on header files #in

[PATCH v2 06/27] gpu: host1x: Cleanup includes

2013-10-07 Thread Thierry Reding
Most of the included files are either not required or already included by some other header file. Signed-off-by: Thierry Reding --- drivers/gpu/host1x/drm/dc.c | 5 + drivers/gpu/host1x/drm/drm.c | 10 -- drivers/gpu/host1x/drm/fb.c | 2 -- drivers/gpu/host1x/drm/gem.