Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-12-13 Thread Matthew Brost
On Fri, Nov 29, 2024 at 11:00:24AM +1100, Alistair Popple wrote: > > Matthew Brost writes: > > [...] > > > + * 3) Invalidation driver vfunc. > > + * > > + * void driver_invalidation(struct drm_gpusvm *gpusvm, > > + * struct drm_gpusvm_notifier *notifier, > > + *

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-28 Thread Alistair Popple
Matthew Brost writes: [...] > + * 3) Invalidation driver vfunc. > + * > + * void driver_invalidation(struct drm_gpusvm *gpusvm, > + *struct drm_gpusvm_notifier *notifier, > + *const struct mmu_notifier_range *mmu_range) > + * { > + *

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-19 Thread Gwan-gyeong Mun
On 10/16/24 6:24 AM, Matthew Brost wrote: + +/** + * drm_gpusvm_get_devmem_page - Get a reference to a device memory page + * @page: Pointer to the page + * @zdd: Pointer to the GPU SVM zone device data + * + * This function associates the given page with the specified GPU SVM zone + * device

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-05 Thread Matthew Brost
On Tue, Nov 05, 2024 at 03:48:24PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > > Continued review: > > > +/** > > + * drm_gpusvm_migrate_unmap_pages() - Unmap pages previously mapped > > for GPU SVM migration > > + * @dev: The device for which the

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-05 Thread Thomas Hellström
On Tue, 2024-11-05 at 08:12 -0800, Matthew Brost wrote: > On Tue, Nov 05, 2024 at 11:22:12AM +0100, Thomas Hellström wrote: > > On Mon, 2024-11-04 at 15:07 -0800, Matthew Brost wrote: > > > > We > > > > have > > > > https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/int > > > > erval_t

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-05 Thread Matthew Brost
On Tue, Nov 05, 2024 at 11:22:12AM +0100, Thomas Hellström wrote: > On Mon, 2024-11-04 at 15:07 -0800, Matthew Brost wrote: > > > We > > > have > > > https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/int > > > erval_tree_generic.h#L24 > > > > > > to relate to. Now GPUVM can't use the

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-05 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: Continued review: > +/** > + * drm_gpusvm_migrate_unmap_pages() - Unmap pages previously mapped > for GPU SVM migration > + * @dev: The device for which the pages were mapped > + * @dma_addr: Array of DMA addresses corresponding to mapped p

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-05 Thread Thomas Hellström
On Mon, 2024-11-04 at 15:07 -0800, Matthew Brost wrote: > > We > > have > > https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/int > > erval_tree_generic.h#L24 > > > > to relate to. Now GPUVM can't use the generic version since it > > needs > > u64 intervals. These trees need unsigned

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Matthew Brost
On Mon, Nov 04, 2024 at 07:59:10PM +0100, Thomas Hellström wrote: > On Mon, 2024-11-04 at 09:21 -0800, Matthew Brost wrote: > > On Mon, Nov 04, 2024 at 04:25:38PM +0100, Thomas Hellström wrote: > > > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > > > > > Continued review. > > > > > >

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Matthew Brost
On Thu, Oct 31, 2024 at 07:58:45PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > This patch introduces support for GPU Shared Virtual Memory (SVM) in > > the > > Direct Rendering Manager (DRM) subsystem. SVM allows for seamless > > sharing of memory be

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Thomas Hellström
On Mon, 2024-11-04 at 09:21 -0800, Matthew Brost wrote: > On Mon, Nov 04, 2024 at 04:25:38PM +0100, Thomas Hellström wrote: > > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > > > Continued review. > > > > > > > > +/** > > > + * struct drm_gpusvm_zdd - GPU SVM zone device data > > >

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Matthew Brost
On Mon, Nov 04, 2024 at 04:25:38PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > Continued review. > > > > > +/** > > + * struct drm_gpusvm_zdd - GPU SVM zone device data > > + * > > + * @refcount: Reference count for the zdd > > + * @destroy_work:

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: Continued review. > > +/** > + * struct drm_gpusvm_zdd - GPU SVM zone device data > + * > + * @refcount: Reference count for the zdd > + * @destroy_work: Work structure for asynchronous zdd destruction > + * @devmem_allocation: device memor

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-10-31 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > This patch introduces support for GPU Shared Virtual Memory (SVM) in > the > Direct Rendering Manager (DRM) subsystem. SVM allows for seamless > sharing of memory between the CPU and GPU, enhancing performance and > flexibility in GPU comput

[PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-10-15 Thread Matthew Brost
This patch introduces support for GPU Shared Virtual Memory (SVM) in the Direct Rendering Manager (DRM) subsystem. SVM allows for seamless sharing of memory between the CPU and GPU, enhancing performance and flexibility in GPU computing tasks. The patch adds the necessary infrastructure for SVM, i