Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-10-22 Thread Boris Brezillon
On Fri, 11 Oct 2019 15:54:53 +0200 Andrzej Hajda wrote: > On 26.08.2019 17:26, Boris Brezillon wrote: > > The encoder->enable() can't report errors and is expected to always > > succeed. If we call pm_runtime_put() in the exynos_dsi_enable() error > > path (as currently done) we'll have unbalance

Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-10-22 Thread Boris Brezillon
On Sat, 12 Oct 2019 09:15:26 +0200 Sam Ravnborg wrote: > Hi Boris/Andrzej. > > > > > > > > > > > > > Note that -ENOSYS is actually a valid case, it just > > > > means the panel driver does not implement the hook. > > > > > > > > > It would be good then to fix it in panel framework,

Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-10-12 Thread Sam Ravnborg
Hi Boris/Andrzej. > > > > > > > > Note that -ENOSYS is actually a valid case, it just > > > means the panel driver does not implement the hook. > > > > > > It would be good then to fix it in panel framework, ie without hook > > drm_panel_* function should return 0, ENOSYS makes no sense her

Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-10-11 Thread Boris Brezillon
On Fri, 11 Oct 2019 15:54:53 +0200 Andrzej Hajda wrote: > On 26.08.2019 17:26, Boris Brezillon wrote: > > The encoder->enable() can't report errors and is expected to always > > succeed. If we call pm_runtime_put() in the exynos_dsi_enable() error > > path (as currently done) we'll have unbalance

Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-10-11 Thread Andrzej Hajda
On 26.08.2019 17:26, Boris Brezillon wrote: > The encoder->enable() can't report errors and is expected to always > succeed. If we call pm_runtime_put() in the exynos_dsi_enable() error > path (as currently done) we'll have unbalanced get/put calls when > encoder->disable() is called. True > >

Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-10-11 Thread Boris Brezillon
Hi Inki, On Mon, 26 Aug 2019 17:26:32 +0200 Boris Brezillon wrote: > The encoder->enable() can't report errors and is expected to always > succeed. If we call pm_runtime_put() in the exynos_dsi_enable() error > path (as currently done) we'll have unbalanced get/put calls when > encoder->disable(

[PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

2019-08-26 Thread Boris Brezillon
The encoder->enable() can't report errors and is expected to always succeed. If we call pm_runtime_put() in the exynos_dsi_enable() error path (as currently done) we'll have unbalanced get/put calls when encoder->disable() is called. The situation is not ideal since drm_panel_{prepare,enable}() ca