Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

2022-09-25 Thread Kees Cook
On Sun, Sep 25, 2022 at 09:17:40AM +0200, Paolo Abeni wrote: > On Fri, 2022-09-23 at 13:28 -0700, Kees Cook wrote: > > All callers of APIs that allowed a 0-sized frag_size appear to be > > passing actual size information already > > AFAICS, not yet: > > drivers/net/ethernet/qlogic/qed/qed_ll2.c:

Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

2022-09-25 Thread Paolo Abeni
On Fri, 2022-09-23 at 13:28 -0700, Kees Cook wrote: > All callers of APIs that allowed a 0-sized frag_size appear to be > passing actual size information already AFAICS, not yet: drivers/net/ethernet/qlogic/qed/qed_ll2.c: skb = build_skb(buffer->data, 0); // -> __build_skb(..., 0) 

[PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

2022-09-23 Thread Kees Cook
All callers of APIs that allowed a 0-sized frag_size appear to be passing actual size information already, so this use of ksize() can be removed. However, just in case there is something still depending on this behavior, issue a WARN and fall back to as before to ksize() which means we'll also pote