Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-30 Thread Peilin Ye
On Mon, Nov 30, 2020 at 08:56:45AM +0100, Sam Ravnborg wrote: > Please just keep up the good work cleaning up fbcon and related stuff. > This is an area that needs some love and care and there is work for many > long nights yet to do. Thanks! I will see what I can do, Peilin Ye _

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-29 Thread Sam Ravnborg
Hi Peilin, On Mon, Nov 30, 2020 at 01:38:05AM -0500, Peilin Ye wrote: > Hi Sam, > > On Sun, Nov 29, 2020 at 12:18:36PM +0100, Sam Ravnborg wrote: > > On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from > > > b

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-29 Thread Peilin Ye
Hi Sam, On Sun, Nov 29, 2020 at 12:18:36PM +0100, Sam Ravnborg wrote: > On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from > > being printed > > when FBCONDEBUG is defined. Is such change what the author of thi

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-29 Thread Tetsuo Handa
On 2020/11/29 19:03, Thomas Zimmermann wrote: > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: >> Replacing DPRINTK() statements with pr_debug fixes set but not used >> warnings.  And moves to a more standard logging setup at the same time. > > I guess this was added for quick debugging during develop

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-29 Thread Sam Ravnborg
On Sun, Nov 29, 2020 at 11:03:25AM +0100, Thomas Zimmermann wrote: > > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > > Replacing DPRINTK() statements with pr_debug fixes set but not used > > warnings. And moves to a more standard logging setup at the same time. > > > > v2: > >- Fix indent

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-29 Thread Sam Ravnborg
Hi Tetsuo, On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > On 2020/11/29 19:03, Thomas Zimmermann wrote: > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > >> Replacing DPRINTK() statements with pr_debug fixes set but not used > >> warnings.  And moves to a more standard logging setup

Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-29 Thread Thomas Zimmermann
Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Replacing DPRINTK() statements with pr_debug fixes set but not used warnings. And moves to a more standard logging setup at the same time. v2: - Fix indent (Joe) Signed-off-by: Sam Ravnborg Cc: Joe Perches Cc: Greg Kroah-Hartman Cc: Daniel Vet

[PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

2020-11-28 Thread Sam Ravnborg
Replacing DPRINTK() statements with pr_debug fixes set but not used warnings. And moves to a more standard logging setup at the same time. v2: - Fix indent (Joe) Signed-off-by: Sam Ravnborg Cc: Joe Perches Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: Bartlomiej Zolnierkiewicz Cc: Sam Ravn