Re: [PATCH v2 02/23] drm: sun4i: de2/de3: Merge CSC functions into one

2024-07-08 Thread Andre Przywara
On Wed, 3 Jul 2024 22:50:52 +1200 Ryan Walklin wrote: Hi, > From: Jernej Skrabec > > Merging both function into one lets this one decide on it's own if CSC > should be enabled or not. "both functions" is not very specific or telling, and left me a bit clueless, so can we maybe use: "At the

[PATCH v2 02/23] drm: sun4i: de2/de3: Merge CSC functions into one

2024-07-03 Thread Ryan Walklin
From: Jernej Skrabec Merging both function into one lets this one decide on it's own if CSC should be enabled or not. Currently heuristics for that is pretty simple - enable it for YUV formats and disable for RGB. However, DE3 can have whole pipeline in RGB or YUV format. YUV pipeline will be sup