Re: [PATCH v2 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-18 Thread Thomas Hellström
On 5/18/21 1:12 PM, Maarten Lankhorst wrote: Hey, This needs a small fix, otherwise looks good. Op 18-05-2021 om 10:26 schreef Thomas Hellström: From: Thomas Hellström Any sleeping dma_resv lock taken while the vma pages_mutex is held will cause a lockdep splat. Move the i915_gem_object_pi

Re: [PATCH v2 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-18 Thread Maarten Lankhorst
Hey, This needs a small fix, otherwise looks good. Op 18-05-2021 om 10:26 schreef Thomas Hellström: > From: Thomas Hellström > > Any sleeping dma_resv lock taken while the vma pages_mutex is held > will cause a lockdep splat. > Move the i915_gem_object_pin_pages() call out of the pages_mutex >

[PATCH v2 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-18 Thread Thomas Hellström
From: Thomas Hellström Any sleeping dma_resv lock taken while the vma pages_mutex is held will cause a lockdep splat. Move the i915_gem_object_pin_pages() call out of the pages_mutex critical section. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_vma.c | 33 +++-