Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Christian König
Am 08.07.21 um 13:20 schrieb Daniel Vetter: On Thu, Jul 8, 2021 at 12:54 PM Christian König wrote: [SNIP] As far as I know that not completely correct. The rules around atomics i once learned are: 1. Everything which modifies something is a write barrier. 2. Everything which returns someth

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Daniel Vetter
On Thu, Jul 8, 2021 at 12:54 PM Christian König wrote: > > Am 08.07.21 um 12:02 schrieb Daniel Vetter: > > On Thu, Jul 08, 2021 at 09:53:00AM +0200, Christian König wrote: > >> Am 08.07.21 um 09:19 schrieb Daniel Vetter: > >>> On Thu, Jul 8, 2021 at 9:09 AM Daniel Vetter > >>> wrote: > On T

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Christian König
Am 08.07.21 um 12:02 schrieb Daniel Vetter: On Thu, Jul 08, 2021 at 09:53:00AM +0200, Christian König wrote: Am 08.07.21 um 09:19 schrieb Daniel Vetter: On Thu, Jul 8, 2021 at 9:09 AM Daniel Vetter wrote: On Thu, Jul 8, 2021 at 8:56 AM Christian König wrote: Am 07.07.21 um 18:32 schrieb Dan

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Daniel Vetter
On Thu, Jul 08, 2021 at 09:53:00AM +0200, Christian König wrote: > Am 08.07.21 um 09:19 schrieb Daniel Vetter: > > On Thu, Jul 8, 2021 at 9:09 AM Daniel Vetter wrote: > > > On Thu, Jul 8, 2021 at 8:56 AM Christian König > > > wrote: > > > > Am 07.07.21 um 18:32 schrieb Daniel Vetter: > > > > > O

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Christian König
Am 08.07.21 um 09:19 schrieb Daniel Vetter: On Thu, Jul 8, 2021 at 9:09 AM Daniel Vetter wrote: On Thu, Jul 8, 2021 at 8:56 AM Christian König wrote: Am 07.07.21 um 18:32 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 2:58 PM Christian König wrote: Am 07.07.21 um 14:13 schrieb Daniel Vetter

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Daniel Vetter
On Thu, Jul 8, 2021 at 9:09 AM Daniel Vetter wrote: > On Thu, Jul 8, 2021 at 8:56 AM Christian König > wrote: > > Am 07.07.21 um 18:32 schrieb Daniel Vetter: > > > On Wed, Jul 7, 2021 at 2:58 PM Christian König > > > wrote: > > >> Am 07.07.21 um 14:13 schrieb Daniel Vetter: > > >>> On Wed, Jul

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-08 Thread Daniel Vetter
On Thu, Jul 8, 2021 at 8:56 AM Christian König wrote: > > Am 07.07.21 um 18:32 schrieb Daniel Vetter: > > On Wed, Jul 7, 2021 at 2:58 PM Christian König > > wrote: > >> Am 07.07.21 um 14:13 schrieb Daniel Vetter: > >>> On Wed, Jul 7, 2021 at 1:57 PM Christian König > >>> wrote: > Am 07.07

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Christian König
Am 07.07.21 um 18:32 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 2:58 PM Christian König wrote: Am 07.07.21 um 14:13 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 1:57 PM Christian König wrote: Am 07.07.21 um 13:14 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 11:30 AM Christian König wr

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Daniel Vetter
On Wed, Jul 7, 2021 at 2:58 PM Christian König wrote: > Am 07.07.21 um 14:13 schrieb Daniel Vetter: > > On Wed, Jul 7, 2021 at 1:57 PM Christian König > > wrote: > >> Am 07.07.21 um 13:14 schrieb Daniel Vetter: > >>> On Wed, Jul 7, 2021 at 11:30 AM Christian König > >>> wrote: > Am 02.07.2

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Christian König
Am 07.07.21 um 14:13 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 1:57 PM Christian König wrote: Am 07.07.21 um 13:14 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 11:30 AM Christian König wrote: Am 02.07.21 um 23:38 schrieb Daniel Vetter: This is a very confusingly named function, because

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Daniel Vetter
On Wed, Jul 7, 2021 at 1:57 PM Christian König wrote: > Am 07.07.21 um 13:14 schrieb Daniel Vetter: > > On Wed, Jul 7, 2021 at 11:30 AM Christian König > > wrote: > >> Am 02.07.21 um 23:38 schrieb Daniel Vetter: > >>> This is a very confusingly named function, because not just does it > >>> init

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Christian König
Am 07.07.21 um 13:14 schrieb Daniel Vetter: On Wed, Jul 7, 2021 at 11:30 AM Christian König wrote: Am 02.07.21 um 23:38 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Daniel Vetter
On Wed, Jul 7, 2021 at 11:30 AM Christian König wrote: > > Am 02.07.21 um 23:38 schrieb Daniel Vetter: > > This is a very confusingly named function, because not just does it > > init an object, it arms it and provides a point of no return for > > pushing a job into the scheduler. It would be nice

Re: [PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-07 Thread Christian König
Am 02.07.21 um 23:38 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is tha

[PATCH v2 01/11] drm/sched: Split drm_sched_job_init

2021-07-02 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking helpe