Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-17 Thread Cornelia Huck
On Fri, Sep 17 2021, Jason Gunthorpe wrote: > On Fri, Sep 17, 2021 at 01:59:16PM +0200, Cornelia Huck wrote: >> >ret = cio_cancel_halt_clear(sch, &iretry); >> > - >> >if (ret == -EIO) { >> >pr_err("vfio_ccw: could not quiesce subchannel >> > 0.%x.%04x!

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-17 Thread Jason Gunthorpe
On Fri, Sep 17, 2021 at 01:59:16PM +0200, Cornelia Huck wrote: > > ret = cio_cancel_halt_clear(sch, &iretry); > > - > > if (ret == -EIO) { > > pr_err("vfio_ccw: could not quiesce subchannel > > 0.%x.%04x!\n", > >sch->schid.ssi

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-17 Thread Cornelia Huck
On Tue, Sep 14 2021, Jason Gunthorpe wrote: > On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: >> > I rebased it and fixed it up here: >> > >> > https://github.com/jgunthorpe/linux/tree/vfio_ccw >> > >> > Can you try again? >> >> That does address the crash, but then why is it proc

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-14 Thread Jason Gunthorpe
On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: > > I rebased it and fixed it up here: > > > > https://github.com/jgunthorpe/linux/tree/vfio_ccw > > > > Can you try again? > > That does address the crash, but then why is it processing a BROKEN > event? Seems problematic. The stuff

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-13 Thread Eric Farman
On Mon, 2021-09-13 at 16:24 -0300, Jason Gunthorpe wrote: > On Mon, Sep 13, 2021 at 01:40:34PM -0400, Eric Farman wrote: > > On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > > > This addresses Cornelia's remark on the earlier patch that ccw > > > has a > > > confusing lifecycle. While it

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-13 Thread Eric Farman
On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > This addresses Cornelia's remark on the earlier patch that ccw has a > confusing lifecycle. While it doesn't seem like the original attempt > was > functionally wrong, the result can be made better with a lot of > further > work. I though

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-13 Thread Jason Gunthorpe
On Mon, Sep 13, 2021 at 01:40:34PM -0400, Eric Farman wrote: > On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > > This addresses Cornelia's remark on the earlier patch that ccw has a > > confusing lifecycle. While it doesn't seem like the original attempt > > was > > functionally wrong,

[PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-09 Thread Jason Gunthorpe
This addresses Cornelia's remark on the earlier patch that ccw has a confusing lifecycle. While it doesn't seem like the original attempt was functionally wrong, the result can be made better with a lot of further work. Reorganize the driver so that the mdev owns the private memory and controls th