Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-10 Thread Maxime Ripard
On Wed, Feb 09, 2022 at 05:32:15PM +0200, Andy Shevchenko wrote: > On Wed, Feb 09, 2022 at 03:42:16PM +0100, Javier Martinez Canillas wrote: > > On 2/9/22 15:27, Geert Uytterhoeven wrote: > > ... > > > Now, this is a reason why I mentioned that the old fbdev driver shouldn't > > be removed yet. >

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-09 Thread Andy Shevchenko
On Wed, Feb 09, 2022 at 03:42:16PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 15:27, Geert Uytterhoeven wrote: ... > Now, this is a reason why I mentioned that the old fbdev driver shouldn't > be removed yet. I agree on this conclusion. I think based on the fbtft resurrection discussion

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-09 Thread Javier Martinez Canillas
Hello Geert, On 2/9/22 15:27, Geert Uytterhoeven wrote: > Hi Andy, > > On Wed, Feb 9, 2022 at 2:48 PM Andy Shevchenko > wrote: >> On Tue, Feb 08, 2022 at 04:10:49PM +0100, Javier Martinez Canillas wrote: >>> On 2/8/22 15:19, Geert Uytterhoeven wrote: On Fri, Feb 4, 2022 at 2:43 PM Javier Ma

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-09 Thread Geert Uytterhoeven
Hi Andy, On Wed, Feb 9, 2022 at 2:48 PM Andy Shevchenko wrote: > On Tue, Feb 08, 2022 at 04:10:49PM +0100, Javier Martinez Canillas wrote: > > On 2/8/22 15:19, Geert Uytterhoeven wrote: > > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > > > wrote: > > > - Kernel size increased by

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-09 Thread Andy Shevchenko
On Tue, Feb 08, 2022 at 04:10:49PM +0100, Javier Martinez Canillas wrote: > On 2/8/22 15:19, Geert Uytterhoeven wrote: > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > > wrote: > > - Kernel size increased by 349 KiB, > > - The "Memory:" line reports 412 KiB less memory, > > - O

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Javier Martinez Canillas
On 2/8/22 16:40, Javier Martinez Canillas wrote: > On 2/8/22 16:23, Geert Uytterhoeven wrote: [snip] >> >> Fbcon does small writes to the shadow frame buffer, while fbtest >> writes to the mmap()ed /dev/fbX, causing a full page to be updated. >> > > I see. Thanks for the information. > I found

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Javier Martinez Canillas
On 2/8/22 16:23, Geert Uytterhoeven wrote: [snip] >>> - The logo (I have a custom monochrome logo enabled) is no longer shown. >> >> I was able to display your tux monochrome with ./fbtest -f /dev/fb1 test004 > > I meant the kernel's logo (FB_LOGO_*),. Obviously you need to enable > a smaller

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Javier Martinez Canillas
Hello Mark, On 2/8/22 16:18, Mark Brown wrote: > On Tue, Feb 08, 2022 at 04:10:49PM +0100, Javier Martinez Canillas wrote: >> On 2/8/22 15:19, Geert Uytterhoeven wrote: > >>> - "time ls" on the serial console (no files in the current directory, >>> so nothing to print) increases from 0.86s

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 8, 2022 at 4:10 PM Javier Martinez Canillas wrote: > On 2/8/22 15:19, Geert Uytterhoeven wrote: > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > > wrote: > >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > >> SSD1307 and SSD1309 d

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Mark Brown
On Tue, Feb 08, 2022 at 04:10:49PM +0100, Javier Martinez Canillas wrote: > On 2/8/22 15:19, Geert Uytterhoeven wrote: > > - "time ls" on the serial console (no files in the current directory, > > so nothing to print) increases from 0.86s to 1.92s, so the system is > > more loaded. As s

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Javier Martinez Canillas
Hello Geert, Thanks a lot for testing! On 2/8/22 15:19, Geert Uytterhoeven wrote: > Hi Javier, > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Geert Uytterhoeven
Hi Javier, On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas wrote: > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. I gave it a try on an Adafruit FeatherWing 128x32 OLED, connected to

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-04 Thread Javier Martinez Canillas
Hello Geert, On 2/4/22 15:31, Geert Uytterhoeven wrote: > Hi Javier, > > On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas > wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. >

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-04 Thread Geert Uytterhoeven
Hi Javier, On Fri, Feb 4, 2022 at 2:43 PM Javier Martinez Canillas wrote: > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. [...] > This is a v2 that addresses all the issues pointed in v1, th

[PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-04 Thread Javier Martinez Canillas
This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. Using the DRM fb emulation, all the tests from Geert Uytterhoeven's fbtest (https://git.kernel.org/pub/scm/linux/kernel/git/geert/fbtest.git) passes: