Re: [PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane

2021-02-09 Thread Hans de Goede
Hi, On 2/9/21 9:13 AM, Thomas Zimmermann wrote: > Hi > > Am 08.02.21 um 18:43 schrieb Hans de Goede: >> Hi, >> >> On 2/8/21 2:50 PM, Thomas Zimmermann wrote: >>> (was: drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb) >>> >>> Functions in the atomic commit tail are not allowed to

Re: [PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane

2021-02-09 Thread Thomas Zimmermann
Hi Am 08.02.21 um 18:43 schrieb Hans de Goede: Hi, On 2/8/21 2:50 PM, Thomas Zimmermann wrote: (was: drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb) Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the G

Re: [PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane

2021-02-08 Thread Hans de Goede
Hi, On 2/8/21 2:50 PM, Thomas Zimmermann wrote: > (was: drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb) > > Functions in the atomic commit tail are not allowed to acquire the > dmabuf's reservation lock. So we cannot legally call the GEM object's > vmap functionality in atomic_

[PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane

2021-02-08 Thread Thomas Zimmermann
(was: drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb) Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the GEM object's vmap functionality in atomic_update. But, much better, we can use drm_shadow_plane_stat