Re: [PATCH v2] xf86drm: Add drmIsMaster()

2019-02-19 Thread Daniel Vetter
On Thu, Jan 24, 2019 at 10:45:04AM +0100, Daniel Vetter wrote: > On Thu, Jan 24, 2019 at 09:56:51AM +1300, Christopher James Halse Rogers > wrote: > > On 24 January 2019 6:18:32 am NZDT, Emil Velikov > > wrote: > > >On Wed, 23 Jan 2019 at 04:39, Christopher James Halse Rogers > > > wrote: > > >>

Re: [PATCH v2] xf86drm: Add drmIsMaster()

2019-01-24 Thread Daniel Vetter
On Thu, Jan 24, 2019 at 09:56:51AM +1300, Christopher James Halse Rogers wrote: > On 24 January 2019 6:18:32 am NZDT, Emil Velikov > wrote: > >On Wed, 23 Jan 2019 at 04:39, Christopher James Halse Rogers > > wrote: > >> > >> We can't use drmSetMaster to query whether or not a drm fd is master > >

Re: [PATCH v2] xf86drm: Add drmIsMaster()

2019-01-23 Thread Christopher James Halse Rogers
On 24 January 2019 6:18:32 am NZDT, Emil Velikov wrote: >On Wed, 23 Jan 2019 at 04:39, Christopher James Halse Rogers > wrote: >> >> We can't use drmSetMaster to query whether or not a drm fd is master >> because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. >> >> Pick DRM_IOCTL_MOD

Re: [PATCH v2] xf86drm: Add drmIsMaster()

2019-01-23 Thread Emil Velikov
On Wed, 23 Jan 2019 at 04:39, Christopher James Halse Rogers wrote: > > We can't use drmSetMaster to query whether or not a drm fd is master > because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. > > Pick DRM_IOCTL_MODE_ATTACHMODE as a long-deprecated ioctl that is > DRM_MASTER but

Re: [PATCH v2] xf86drm: Add drmIsMaster()

2019-01-23 Thread Daniel Vetter
On Wed, Jan 23, 2019 at 03:38:45PM +1100, Christopher James Halse Rogers wrote: > We can't use drmSetMaster to query whether or not a drm fd is master > because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. > > Pick DRM_IOCTL_MODE_ATTACHMODE as a long-deprecated ioctl that is > DRM_M

[PATCH v2] xf86drm: Add drmIsMaster()

2019-01-22 Thread Christopher James Halse Rogers
We can't use drmSetMaster to query whether or not a drm fd is master because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. Pick DRM_IOCTL_MODE_ATTACHMODE as a long-deprecated ioctl that is DRM_MASTER but not DRM_ROOT_ONLY as the probe by which we can detect whether or not the fd is m