[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-23 Thread Tobias Jakobi
Hello Ilia! On 2015-04-23 16:32, Ilia Mirkin wrote: > On Thu, Apr 23, 2015 at 9:39 AM, Tobias Jakobi > wrote: >> Hello Ilia, >> >> On 2015-04-21 21:15, Ilia Mirkin wrote: >>> >>> I know it was immensely useful to me when I was adding YUV plane >>> support to nouveau. Seemed to work as advertis

[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-23 Thread Emil Velikov
Hi Ilia, On 21/04/15 19:15, Ilia Mirkin wrote: > On Tue, Apr 21, 2015 at 4:10 PM, Emil Velikov > wrote: >> Hi Tobias, >> >> On 20/04/15 19:50, Tobias Jakobi wrote: >>> Only the 'offsets' array was initialized to zero. >>> Since bo_create only sets the handles which are >>> necessary, were we pas

[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-23 Thread Tobias Jakobi
Hello Ilia, On 2015-04-21 21:15, Ilia Mirkin wrote: > I know it was immensely useful to me when I was adding YUV plane > support to nouveau. Seemed to work as advertised at the time (1.5y > ago) for YUYV, UYVY, and NV12. > > -ilia maybe you can help me with that question. Let's consider a user

[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-23 Thread Ilia Mirkin
On Thu, Apr 23, 2015 at 9:39 AM, Tobias Jakobi wrote: > Hello Ilia, > > On 2015-04-21 21:15, Ilia Mirkin wrote: >> >> I know it was immensely useful to me when I was adding YUV plane >> support to nouveau. Seemed to work as advertised at the time (1.5y >> ago) for YUYV, UYVY, and NV12. >> >> -il

[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-21 Thread Emil Velikov
Hi Tobias, On 20/04/15 19:50, Tobias Jakobi wrote: > Only the 'offsets' array was initialized to zero. > Since bo_create only sets the handles which are > necessary, were we passing garbage data to the > kernel when calling drmModeAddFB2 later. > > The issue only seems to appear when passing e.g.

[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-21 Thread Ilia Mirkin
On Tue, Apr 21, 2015 at 4:10 PM, Emil Velikov wrote: > Hi Tobias, > > On 20/04/15 19:50, Tobias Jakobi wrote: >> Only the 'offsets' array was initialized to zero. >> Since bo_create only sets the handles which are >> necessary, were we passing garbage data to the >> kernel when calling drmModeAdd

[PATCH v2] modetest: initialize handles/pitches in set_plane()

2015-04-20 Thread Tobias Jakobi
Only the 'offsets' array was initialized to zero. Since bo_create only sets the handles which are necessary, were we passing garbage data to the kernel when calling drmModeAddFB2 later. The issue only seems to appear when passing e.g. NV12 data to the kernel, a case where not only handles[0] is us