Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Javier Martinez Canillas
Julius Werner writes: Hello Julius, >> + /* >> +* On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry >> +* in the Coreboot table should only be used if the payload did >> +* not pass a framebuffer information to the Linux kernel. > > nit: The official bran

Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Julius Werner
> + /* > +* On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry > +* in the Coreboot table should only be used if the payload did > +* not pass a framebuffer information to the Linux kernel. nit: The official brand spelling is "coreboot", always lowercase (ev

[PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-13 Thread Javier Martinez Canillas
On Coreboot platforms, a system framebuffer may be provided to the Linux kernel by filling a LB_TAG_FRAMEBUFFER entry in the Coreboot table. But a Coreboot payload (e.g: SeaBIOS) could also provide its own framebuffer information to the Linux kernel. If that's the case, arch x86 boot code will fil