Hi
Am 19.04.23 um 22:27 schrieb Pierre Asselin:
Thomas Zimmermann wrote:
Am 19.04.23 um 06:48 schrieb Pierre Asselin:
v2 fixes the warnings from a max3() macro with arguments of different
types; split the bits_per_pixel assignment to avoid uglyfing the code
with too many typecasts.
What e
Thomas Zimmermann wrote:
> Am 19.04.23 um 06:48 schrieb Pierre Asselin:
>>
>> v2 fixes the warnings from a max3() macro with arguments of different
>> types; split the bits_per_pixel assignment to avoid uglyfing the code
>> with too many typecasts.
>
> What exactly was that warning?
A friendly n
Javier Martinez Canillas writes:
> Pierre Asselin writes:
>> Fixes: f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection]
>
> The convention is f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format
> selection")
>> +bits_per_pixel= max(bits_per_pixel, (u32)si->lfb_depth);
>
> Yo
Pierre Asselin writes:
Hello Pierre,
> Some legacy BIOSes report no reserved bits in their 32-bit rgb mode,
> breaking the calculation of bits_per_pixel in commit f35cd3fa7729
> [firmware/sysfb: Fix EFI/VESA format selection]. However they report
> lfb_depth correctly for those modes. Keep the
Hi
Am 19.04.23 um 06:48 schrieb Pierre Asselin:
Some legacy BIOSes report no reserved bits in their 32-bit rgb mode,
breaking the calculation of bits_per_pixel in commit f35cd3fa7729
[firmware/sysfb: Fix EFI/VESA format selection]. However they report
lfb_depth correctly for those modes. Keep
Some legacy BIOSes report no reserved bits in their 32-bit rgb mode,
breaking the calculation of bits_per_pixel in commit f35cd3fa7729
[firmware/sysfb: Fix EFI/VESA format selection]. However they report
lfb_depth correctly for those modes. Keep the computation but
set bits_per_pixel to lfb_depth
