Re: [PATCH v2] fbdev: potential information leak in do_fb_ioctl()

2020-01-15 Thread Bartlomiej Zolnierkiewicz
On 1/13/20 12:08 PM, Dan Carpenter wrote: > The "fix" struct has a 2 byte hole after ->ywrapstep and the > "fix = info->fix;" assignment doesn't necessarily clear it. It depends > on the compiler. The solution is just to replace the assignment with an > memcpy(). > > Fixes: 1f5e31d7e55a ("fbme

[PATCH v2] fbdev: potential information leak in do_fb_ioctl()

2020-01-13 Thread Dan Carpenter
The "fix" struct has a 2 byte hole after ->ywrapstep and the "fix = info->fix;" assignment doesn't necessarily clear it. It depends on the compiler. The solution is just to replace the assignment with an memcpy(). Fixes: 1f5e31d7e55a ("fbmem: don't call copy_from/to_user() with mutex held") Sign