Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread Shixiong Ou
在 2025/2/19 14:47, Arnd Bergmann 写道: On Sat, Feb 8, 2025, at 10:29, oushixiong1...@163.com wrote: From: Shixiong Ou 1. The device_remove_file() need to be called when driver is removing. 2. The device_remove_file() need to be called if the call to device_create_file() fails. This should

Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread Arnd Bergmann
On Sat, Feb 8, 2025, at 10:29, oushixiong1...@163.com wrote: > From: Shixiong Ou > > 1. The device_remove_file() need to be called when driver is removing. > 2. The device_remove_file() need to be called if the call to >device_create_file() fails. This should probably use device_add_group() i

Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread kernel test robot
e/leds.git for-leds-next patch link: https://lore.kernel.org/r/20250208092918.251733-1-oushixiong1025%40163.com patch subject: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file() config: nios2-randconfig-r072-20250219 (https://download.01.org/0day-ci/archive/20250219/20250219120

[PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-08 Thread oushixiong1025
From: Shixiong Ou 1. The device_remove_file() need to be called when driver is removing. 2. The device_remove_file() need to be called if the call to device_create_file() fails. Signed-off-by: Shixiong Ou --- v1->v2: add missing 'return error'. call device_remove_file() in sh