Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
On 11/16/21 11:01, Javier Martinez Canillas wrote: > Hello Geert, > > On 11/16/21 10:43, Geert Uytterhoeven wrote: > > [snip] > >>> >>> So this is already a fragile solution and $SUBJECT doesn't make things worse >>> IMO. Since not having something like this can lead to issues as reported by: >>

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
Hello Geert, On 11/16/21 10:43, Geert Uytterhoeven wrote: [snip] >> >> So this is already a fragile solution and $SUBJECT doesn't make things worse >> IMO. Since not having something like this can lead to issues as reported by: >> >> https://lore.kernel.org/all/2020200253.rfudkt3edbd3nsyj@la

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Geert Uytterhoeven
Hi Javier, On Tue, Nov 16, 2021 at 10:30 AM Javier Martinez Canillas wrote: > On 11/15/21 17:20, Geert Uytterhoeven wrote: > >> @@ -351,6 +351,17 @@ static int efifb_probe(struct platform_device *dev) > >> char *option = NULL; > >> efi_memory_desc_t md; > >> > >> + /* > >> +

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
Hello Geert, On 11/15/21 17:20, Geert Uytterhoeven wrote: [snip] >> @@ -351,6 +351,17 @@ static int efifb_probe(struct platform_device *dev) >> char *option = NULL; >> efi_memory_desc_t md; >> >> + /* >> +* Generic drivers must not be registered if a framebuffer exi

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-15 Thread Geert Uytterhoeven
Hi Javier, On Thu, Nov 11, 2021 at 12:13 PM Javier Martinez Canillas wrote: > The efifb and simplefb drivers just render to a pre-allocated frame buffer > and rely on the display hardware being initialized before the kernel boots. > > But if another driver already probed correctly and registered

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-12 Thread Daniel Vetter
On Thu, Nov 11, 2021 at 12:39:28PM +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 11, 2021 at 12:11:20PM +0100, Javier Martinez Canillas wrote: > > The efifb and simplefb drivers just render to a pre-allocated frame buffer > > and rely on the display hardware being initialized before the kernel boo

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-11 Thread Greg Kroah-Hartman
On Thu, Nov 11, 2021 at 12:11:20PM +0100, Javier Martinez Canillas wrote: > The efifb and simplefb drivers just render to a pre-allocated frame buffer > and rely on the display hardware being initialized before the kernel boots. > > But if another driver already probed correctly and registered a f

[PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-11 Thread Javier Martinez Canillas
The efifb and simplefb drivers just render to a pre-allocated frame buffer and rely on the display hardware being initialized before the kernel boots. But if another driver already probed correctly and registered a fbdev, the generic drivers shouldn't be probed since an actual driver for the displ