Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-19 Thread Paulo Pavacic
> So, the driver has to be panel-fannal-c3004.c and binding to be > fannal,c3004.yaml. I believe I have covered this and all the other problems in following patch which I will submit as a V3 of the conversation in a patchset together with a driver: Add dt-bindings documentation for panel-mipi-ds

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-18 Thread Conor Dooley
On Thu, May 18, 2023 at 04:47:08PM +0200, Paulo Pavacic wrote: > > So, the driver has to be panel-fannal-c3004.c and binding to be > > fannal,c3004.yaml. > > I believe I have covered this and all the other problems in following > patch which I will submit as a V3 of the conversation in a patchset

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-18 Thread Paulo
On Wed, May 17 2023 at 05:50:22 PM +0530, Jagan Teki wrote: > Just to add a few pieces of information for you to understand better > on the context of dsi panels. DSI panels can be part of panel-simple.c > or panel-.c DSI panels whose init and exit sequence is > generic are suitable to add it i

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-18 Thread Paulo Pavacic
Hello, If I understood you correctly you'd prefer it to be named fannal,c3004.yaml? My logic is that if more panels were to be added that means that each one would have yaml files that would look exactly the same with the same user. Best regards, Paulo On 5/17/23 09:03, Krzysztof Kozlowski

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Jagan Teki
Hi, Please don't post, use inline replies. On Wed, May 17, 2023 at 6:34 PM Paulo wrote: > > On Wed, May 17 2023 at 05:50:22 PM +0530, Jagan Teki > wrote: > > Just to add a few pieces of information for you to understand better > > on the context of dsi panels. DSI panels can be part of > pane

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Jagan Teki
On Wed, May 17, 2023 at 12:39 PM Paulo Pavacic wrote: > > Hello, thank you for your time to review this patch and sorry for not > addressing all of the concerns, it was done unintentionally. This is > my first contribution to the Linux kernel and it is quite a process. > I have run those two scrip

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Dave Stevenson
Hi Paulo On Tue, 16 May 2023 at 14:09, Paulo Pavačić wrote: > > Add dt-bindings documentation for panel-mipi-dsi-bringup which currently > supports fannal,c3004 panel. Also added fannal to vendor-prefixes. > > v2 changelog: > - revised driver title, now describes purpose > - revised descripti

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Krzysztof Kozlowski
On 17/05/2023 10:29, Paulo Pavacic wrote: > Hello, > > If I understood you correctly you'd prefer it to be named > fannal,c3004.yaml? This is what I wrote: "Judging by compatible, this should be fannal,c3004.yaml" > My logic is that if more panels were to be added that > means that each one w

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Paulo Pavacic
Hello, thank you for your time to review this patch and sorry for not addressing all of the concerns, it was done unintentionally. This is my first contribution to the Linux kernel and it is quite a process. I have run those two scripts and haven't received any errors I have latest master cloned so

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Paulo Pavacic
Hello, thank you for your time to review this patch and sorry for not addressing all of the concerns, it was done unintentionally. This is my first contribution to the Linux kernel and it is quite a process. I have run those two scripts and haven't received any errors I have latest master cloned so

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-17 Thread Krzysztof Kozlowski
On 17/05/2023 00:13, Paulo Pavacic wrote: > Hello, thank you for your time to review this patch and sorry for not > addressing all of the concerns, it was done unintentionally. This is > my first contribution to the Linux kernel and it is quite a process. > I have run those two scripts and haven't

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-16 Thread Krzysztof Kozlowski
On 16/05/2023 15:09, Paulo Pavačić wrote: > Add dt-bindings documentation for panel-mipi-dsi-bringup which currently > supports fannal,c3004 panel. Also added fannal to vendor-prefixes. Thank you for your patch. There is something to discuss/improve. > > v2 changelog: Please put changelog after

[PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-16 Thread Paulo Pavačić
Add dt-bindings documentation for panel-mipi-dsi-bringup which currently supports fannal,c3004 panel. Also added fannal to vendor-prefixes. v2 changelog: - revised driver title, now describes purpose - revised description, now describes hw - revised maintainers, now has only 1 mail - remov