Re: [PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-07 Thread Andy Shevchenko
On Wed, Feb 05, 2020 at 07:33:22PM +0200, Laurent Pinchart wrote: > Hi Andy, > > Thank you for the patch. > > On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote: > > This file doesn't need everything provided by . > > All it needs are some types, which are provided by . > > > > Note

[PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-06 Thread Andy Shevchenko
This file doesn't need everything provided by . All it needs are some types, which are provided by . Note, already includes , but not relying on implicit includes is indeed a good thing. Signed-off-by: Andy Shevchenko --- v2: Update commit message (Geert, Laurent) include/linux/platform_data/s

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-05 Thread Laurent Pinchart
Hi Andy, Thank you for the patch. On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote: > This file doesn't need everything provided by . > All it needs are some types, which are provided by . > > Note, already includes , but > not relying on implicit includes is indeed a good thing.

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-05 Thread Kieran Bingham
Hi Andy, On 05/02/2020 09:32, Andy Shevchenko wrote: > This file doesn't need everything provided by . > All it needs are some types, which are provided by . > > Note, already includes , but > not relying on implicit includes is indeed a good thing. This explains things a bit better :-) I'm su