Re: [PATCH v2] drm: rcar-du: fix possible object reference leak

2019-04-09 Thread Mukesh Ojha
On 4/8/2019 8:28 AM, Wen Yang wrote: The call to of_get_parent returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing of_node_p

Re: [PATCH v2] drm: rcar-du: fix possible object reference leak

2019-04-09 Thread wen.yang99
> > The call to of_get_parent returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > > Detected by coccinelle with the following warnings: > > drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing of_node_put; > > acquired

Re: [PATCH v2] drm: rcar-du: fix possible object reference leak

2019-04-09 Thread Markus Elfring
> v2->v1: turn the return into a goto done. * The version identification can be shorter, can't it? * The expection handling should be completed for the implementation of the function “rcar_du_of_lvds_patch” in a different way. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g

[PATCH v2] drm: rcar-du: fix possible object reference leak

2019-04-08 Thread Wen Yang
The call to of_get_parent returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing of_node_put; acquired a node pointer with refcou