Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling

2019-09-10 Thread Dan Carpenter
On Sun, Sep 08, 2019 at 06:04:28PM +0200, Sam Ravnborg wrote: > Hi Dan. > > On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote: > > The "lvds->backlight" pointer could be NULL in situations were > > of_parse_phandle() returns NULL. Also it's slightly cleaner to use > > backlight_put()

Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling

2019-09-08 Thread Sam Ravnborg
Hi Dan. On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote: > The "lvds->backlight" pointer could be NULL in situations were > of_parse_phandle() returns NULL. Also it's slightly cleaner to use > backlight_put() which already has a check for NULL built in. > > Fixes: 7c9dff5bd643 ("dr

Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling

2019-09-04 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote: > The "lvds->backlight" pointer could be NULL in situations were > of_parse_phandle() returns NULL. Also it's slightly cleaner to use > backlight_put() which already has a check for NULL built in. >

[PATCH v2] drm: panel-lvds: Potential Oops in probe error handling

2019-09-04 Thread Dan Carpenter
The "lvds->backlight" pointer could be NULL in situations were of_parse_phandle() returns NULL. Also it's slightly cleaner to use backlight_put() which already has a check for NULL built in. Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") Signed-off-by: Dan Carpenter --- v2: Use backl