Re: [PATCH v2] drm: Set vm_ops to GEM object's values during mmap

2021-01-15 Thread Thomas Zimmermann
Hi Am 15.01.21 um 15:11 schrieb Daniel Vetter: On Fri, Jan 15, 2021 at 09:57:24AM +, Kieran Bingham wrote: Hi Thomas, On 15/01/2021 09:30, Thomas Zimmermann wrote: The GEM mmap code relies on the GEM object's mmap callback to set the VMA's vm_ops field. This is easily forgotten and alread

Re: [PATCH v2] drm: Set vm_ops to GEM object's values during mmap

2021-01-15 Thread Daniel Vetter
On Fri, Jan 15, 2021 at 09:57:24AM +, Kieran Bingham wrote: > Hi Thomas, > > On 15/01/2021 09:30, Thomas Zimmermann wrote: > > The GEM mmap code relies on the GEM object's mmap callback to set the > > VMA's vm_ops field. This is easily forgotten and already led to a memory > > leak in the CMA

Re: [PATCH v2] drm: Set vm_ops to GEM object's values during mmap

2021-01-15 Thread Kieran Bingham
Hi Thomas, On 15/01/2021 09:30, Thomas Zimmermann wrote: > The GEM mmap code relies on the GEM object's mmap callback to set the > VMA's vm_ops field. This is easily forgotten and already led to a memory > leak in the CMA helpers. Instead set the vm_ops field in the DRM core > code to the GEM obje

[PATCH v2] drm: Set vm_ops to GEM object's values during mmap

2021-01-15 Thread Thomas Zimmermann
The GEM mmap code relies on the GEM object's mmap callback to set the VMA's vm_ops field. This is easily forgotten and already led to a memory leak in the CMA helpers. Instead set the vm_ops field in the DRM core code to the GEM object's value. Drivers with different needs can override this in thei