Re: [PATCH v2] drm: Rely on mode_config data for fb_helper initialization

2017-03-01 Thread Daniel Vetter
On Wed, Mar 01, 2017 at 04:01:05PM -0300, Gabriel Krisman Bertazi wrote: > Daniel Vetter writes: > > > You forgot to update the kernel-doc, building them now generates new > > warnings. Please fix in a follow-up patch. > > Hm, that´s a bummer. Please take the fix below. Thanks for spotting. A

Re: [PATCH v2] drm: Rely on mode_config data for fb_helper initialization

2017-03-01 Thread Gabriel Krisman Bertazi
Daniel Vetter writes: > You forgot to update the kernel-doc, building them now generates new > warnings. Please fix in a follow-up patch. Hm, that´s a bummer. Please take the fix below. Thanks for spotting. -- >8 -- Subject: [PATCH] drm: Update drm_fbdev_cma_init documentation Commit be7f735

Re: [PATCH v2] drm: Rely on mode_config data for fb_helper initialization

2017-03-01 Thread Daniel Vetter
On Thu, Feb 02, 2017 at 02:26:40PM -0200, Gabriel Krisman Bertazi wrote: > Instead of receiving the num_crts as a parameter, we can read it > directly from the mode_config structure. I audited the drivers that > invoke this helper and I believe all of them initialize the mode_config > struct accor

Re: [PATCH v2] drm: Rely on mode_config data for fb_helper initialization

2017-02-02 Thread Daniel Vetter
On Thu, Feb 02, 2017 at 02:26:40PM -0200, Gabriel Krisman Bertazi wrote: > Instead of receiving the num_crts as a parameter, we can read it > directly from the mode_config structure. I audited the drivers that > invoke this helper and I believe all of them initialize the mode_config > struct accor

[PATCH v2] drm: Rely on mode_config data for fb_helper initialization

2017-02-02 Thread Gabriel Krisman Bertazi
Instead of receiving the num_crts as a parameter, we can read it directly from the mode_config structure. I audited the drivers that invoke this helper and I believe all of them initialize the mode_config struct accordingly, prior to calling the fb_helper. I used the following coccinelle hack to