Re: [PATCH v2] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-19 Thread Melissa Wen
On 03/17, Maíra Canal wrote: > Hi Melissa, > > On 3/17/24 14:50, Melissa Wen wrote: > > On 03/16, Arthur Grillo wrote: > > > As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > > > To round a number, you need to add 0.5 to the number and floor that, > > > drm_fixp2int_round()

Re: [PATCH v2] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-17 Thread Maíra Canal
Hi Melissa, On 3/17/24 14:50, Melissa Wen wrote: On 03/16, Arthur Grillo wrote: As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. To round a number, you need to add 0.5 to the number and floor that, drm_fixp2int_round() is adding 0.076. Make it add 0.5. [1]: https://

Re: [PATCH v2] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-17 Thread Melissa Wen
On 03/16, Arthur Grillo wrote: > As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > To round a number, you need to add 0.5 to the number and floor that, > drm_fixp2int_round() is adding 0.076. Make it add 0.5. > > [1]: > https://lore.kernel.org/all/20240301135327.22efe0

[PATCH v2] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-16 Thread Arthur Grillo
As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. To round a number, you need to add 0.5 to the number and floor that, drm_fixp2int_round() is adding 0.076. Make it add 0.5. [1]: https://lore.kernel.org/all/20240301135327.22efe0dd.pekka.paala...@collabora.com/ Fixes: 8b