Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Ville Syrjälä
On Tue, Aug 28, 2018 at 04:58:42PM +0100, Alexandru-Cosmin Gheorghe wrote: > On Tue, Aug 28, 2018 at 06:46:07PM +0300, Ville Syrjälä wrote: > > On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: > > > When doing suspend/resume drivers usually use the > > > drm_atomic_helper_suspend

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Brian Starkey
On Tue, Aug 28, 2018 at 05:08:51PM +0100, Alexandru-Cosmin Gheorghe wrote: On Tue, Aug 28, 2018 at 04:48:45PM +0100, Brian Starkey wrote: Hi Alex, On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: >When doing suspend/resume drivers usually use the >drm_atomic_helper_suspend/dr

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Alexandru-Cosmin Gheorghe
On Tue, Aug 28, 2018 at 04:48:45PM +0100, Brian Starkey wrote: > Hi Alex, > > On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: > >When doing suspend/resume drivers usually use the > >drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > >state and then re-comi

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Alexandru-Cosmin Gheorghe
On Tue, Aug 28, 2018 at 06:46:07PM +0300, Ville Syrjälä wrote: > On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: > > When doing suspend/resume drivers usually use the > > drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > > state and then re-comitting it. >

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Brian Starkey
Hi Alex, On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: When doing suspend/resume drivers usually use the drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the state and then re-comitting it. The problem is that drm_crtc_state has a bool field called color_

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Ville Syrjälä
On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: > When doing suspend/resume drivers usually use the > drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > state and then re-comitting it. > > The problem is that drm_crtc_state has a bool field called > color_

[PATCH v2] drm: Fix crtc color management when doing suspend/resume

2018-08-28 Thread Alexandru Gheorghe
When doing suspend/resume drivers usually use the drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the state and then re-comitting it. The problem is that drm_crtc_state has a bool field called color_mgmt_changed, which mali-dp and other drivers uses it to detect if coefficients