Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-11 Thread Ville Syrjälä
On Tue, Sep 11, 2018 at 04:48:42PM +0100, Alexandru-Cosmin Gheorghe wrote: > On Tue, Sep 11, 2018 at 04:45:25PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 11, 2018 at 02:20:22PM +0100, Alexandru-Cosmin Gheorghe wrote: > > > Hi Ville, > > > > > > On Tue, Sep 11, 2018 at 03:27:09PM +0300, Ville Syr

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-11 Thread Alexandru-Cosmin Gheorghe
On Tue, Sep 11, 2018 at 04:45:25PM +0300, Ville Syrjälä wrote: > On Tue, Sep 11, 2018 at 02:20:22PM +0100, Alexandru-Cosmin Gheorghe wrote: > > Hi Ville, > > > > On Tue, Sep 11, 2018 at 03:27:09PM +0300, Ville Syrjälä wrote: > > > On Mon, Sep 10, 2018 at 06:29:46PM +0100, Alexandru Gheorghe wrote:

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-11 Thread Ville Syrjälä
On Tue, Sep 11, 2018 at 02:20:22PM +0100, Alexandru-Cosmin Gheorghe wrote: > Hi Ville, > > On Tue, Sep 11, 2018 at 03:27:09PM +0300, Ville Syrjälä wrote: > > On Mon, Sep 10, 2018 at 06:29:46PM +0100, Alexandru Gheorghe wrote: > > > DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit uncl

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-11 Thread Alexandru-Cosmin Gheorghe
Hi Ville, On Tue, Sep 11, 2018 at 03:27:09PM +0300, Ville Syrjälä wrote: > On Mon, Sep 10, 2018 at 06:29:46PM +0100, Alexandru Gheorghe wrote: > > DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear > > to me, so try to clarify that with a bit of ascii graphics. > > > > Changes

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-11 Thread Ville Syrjälä
On Mon, Sep 10, 2018 at 06:29:46PM +0100, Alexandru Gheorghe wrote: > DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear > to me, so try to clarify that with a bit of ascii graphics. > > Changes since v1: > - Move the ascii graphics in the kerneldoc where all plane > prope

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-10 Thread Daniel Vetter
On Mon, Sep 10, 2018 at 06:29:46PM +0100, Alexandru Gheorghe wrote: > DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear > to me, so try to clarify that with a bit of ascii graphics. > > Changes since v1: > - Move the ascii graphics in the kerneldoc where all plane > prope

[PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

2018-09-10 Thread Alexandru Gheorghe
DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear to me, so try to clarify that with a bit of ascii graphics. Changes since v1: - Move the ascii graphics in the kerneldoc where all plane properties are already documented and make sure it's properly rendered, suggestes