Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 12:25:22PM +0100, Maxime Ripard wrote: > Hi! > > On Tue, Nov 03, 2020 at 11:55:08AM +0100, Daniel Vetter wrote: > > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > > > On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > >

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Maxime Ripard
Hi! On Tue, Nov 03, 2020 at 11:55:08AM +0100, Daniel Vetter wrote: > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > > On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 03.11.20 um 10:52 schrieb Maxime Ripard: > > > > On Tue, Nov 03, 2020

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Maxime Ripard
On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fixed the wrong parameter. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/drm_drv.c | 23 ++

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Maxime Ripard
On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.11.20 um 10:52 schrieb Maxime Ripard: > > On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > >> Add new api devm_drm_irq_install() to register interrupts, > >> no need to call drm_irq_uninstall() when the dr

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread tiantao (H)
在 2020/11/3 15:56, Thomas Zimmermann 写道: Hi Thanks, the code looks good already. There just are a few nits below. Thanks for the help with the review code. Add the new api devm_drm_irq_install and himbc use the new interface as one patch or two? Am 03.11.20 um 03:10 schrieb Tian Tao: Ad

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 12:25:06PM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.11.20 um 11:55 schrieb Daniel Vetter: > > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > >> On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > >>> Hi > >>> > >>> Am 03.11.20 um 10:

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Thomas Zimmermann
Hi Am 03.11.20 um 11:55 schrieb Daniel Vetter: > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: >> On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 03.11.20 um 10:52 schrieb Maxime Ripard: On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao w

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 03.11.20 um 10:52 schrieb Maxime Ripard: > > > On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > > >> Add new api devm_drm_irq_install() t

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fixed the wrong parameter. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/drm_drv.c | 23 ++

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Thomas Zimmermann
Hi Am 03.11.20 um 10:52 schrieb Maxime Ripard: > On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: >> Add new api devm_drm_irq_install() to register interrupts, >> no need to call drm_irq_uninstall() when the drm module is removed. >> >> v2: >> fixed the wrong parameter. >> >> Signed-off-b

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Sam Ravnborg
Hi Tian. Good to see more infrastructure support so one does not have to think about cleanup. On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fi

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Thomas Zimmermann
Hi Am 03.11.20 um 09:57 schrieb tiantao (H): > > > 在 2020/11/3 15:56, Thomas Zimmermann 写道: >> Hi >> >> Thanks, the code looks good already. There just are a few nits below. >> > Thanks for the help with the review code. > Add the new api devm_drm_irq_install and himbc use the new interface as >

[PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Tian Tao
Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. v2: fixed the wrong parameter. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_drv.c | 23 +++ include/drm/drm_drv.h | 3 ++- 2 files changed,

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-02 Thread Thomas Zimmermann
Hi Thanks, the code looks good already. There just are a few nits below. Am 03.11.20 um 03:10 schrieb Tian Tao: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fixed the wrong parameter. > > Signed-off-