Re: [PATCH v2] drm/v3d: fix missing unlock

2022-01-28 Thread Melissa Wen
On 01/27, Yongzhi Liu wrote: > [why] > Unlock is needed on the error handling path to prevent dead lock. > v3d_submit_cl_ioctl and v3d_submit_csd_ioctl is missing unlock. > > [how] > Fix this by change goto target on the error handling path. s/change/changing/g I would just say: `Changing the got

[PATCH v2] drm/v3d: fix missing unlock

2022-01-27 Thread Yongzhi Liu
[why] Unlock is needed on the error handling path to prevent dead lock. v3d_submit_cl_ioctl and v3d_submit_csd_ioctl is missing unlock. [how] Fix this by change goto target on the error handling path. As unlock is handle in fail_unreserve, i keep the failures handling around there. So the goto tar