Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Laurent Pinchart
Hi Jyri, On Thu, Feb 13, 2020 at 11:03:15AM +0200, Jyri Sarha wrote: > On 12/02/2020 22:28, Daniel Vetter wrote: > > On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: > >> On 12/02/2020 16:33, Ville Syrjälä wrote: > >>> On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: > On 12/02/2

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Daniel Vetter
On Thu, Feb 13, 2020 at 12:03:51PM +0200, Jyri Sarha wrote: > On 13/02/2020 11:19, Daniel Vetter wrote: > > On Thu, Feb 13, 2020 at 10:03 AM Jyri Sarha wrote: > >> > >> On 12/02/2020 22:28, Daniel Vetter wrote: > >>> On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: > > On 12/02/2020 16

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 13/02/2020 11:19, Daniel Vetter wrote: > On Thu, Feb 13, 2020 at 10:03 AM Jyri Sarha wrote: >> >> On 12/02/2020 22:28, Daniel Vetter wrote: >>> On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: On 12/02/2020 16:33, Ville Syrjälä wrote: > On Wed, Feb 12, 2020 at 04:08:11PM +0200,

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Daniel Vetter
On Thu, Feb 13, 2020 at 10:03 AM Jyri Sarha wrote: > > On 12/02/2020 22:28, Daniel Vetter wrote: > > On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: > >> > >> On 12/02/2020 16:33, Ville Syrjälä wrote: > >>> On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: > On 12/02/2020 15:59,

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 12/02/2020 22:28, Daniel Vetter wrote: > On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: >> >> On 12/02/2020 16:33, Ville Syrjälä wrote: >>> On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: On 12/02/2020 15:59, Jyri Sarha wrote: > The old implementation of placing planes o

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Daniel Vetter
On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: > > On 12/02/2020 16:33, Ville Syrjälä wrote: > > On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: > >> On 12/02/2020 15:59, Jyri Sarha wrote: > >>> The old implementation of placing planes on the CRTC while configuring > >>> the planes

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 12/02/2020 16:33, Ville Syrjälä wrote: > On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: >> On 12/02/2020 15:59, Jyri Sarha wrote: >>> The old implementation of placing planes on the CRTC while configuring >>> the planes was naive and relied on the order in which the planes were >>>

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Ville Syrjälä
On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: > On 12/02/2020 15:59, Jyri Sarha wrote: > > The old implementation of placing planes on the CRTC while configuring > > the planes was naive and relied on the order in which the planes were > > configured, enabled, and disabled. The situat

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 12/02/2020 15:59, Jyri Sarha wrote: > The old implementation of placing planes on the CRTC while configuring > the planes was naive and relied on the order in which the planes were > configured, enabled, and disabled. The situation where a plane's zpos > was changed on the fly was completely bro

[PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
The old implementation of placing planes on the CRTC while configuring the planes was naive and relied on the order in which the planes were configured, enabled, and disabled. The situation where a plane's zpos was changed on the fly was completely broken. The usual symptoms of this problem was scr