Re: [PATCH v2] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-12 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, Thanks for your feedback! > Hi, > > On Sun, Sep 10, 2023 at 11:40:28AM +0200, Javier Martinez Canillas wrote: [...] >> static int ssd130x_update_rect(struct ssd130x_device *ssd130x, >> - struct ssd130x_plane_state *ssd130x_state,

Re: [PATCH v2] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-12 Thread Maxime Ripard
Hi, On Sun, Sep 10, 2023 at 11:40:28AM +0200, Javier Martinez Canillas wrote: > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > .atomic_check() callback") moved the allocation of the intermediate and > HW buffers from the encoder's .atomic_enable callback, to the plane's >

[PATCH v2] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-10 Thread Javier Martinez Canillas
The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") moved the allocation of the intermediate and HW buffers from the encoder's .atomic_enable callback, to the plane's .atomic_check callback. This was suggested by Maxime Ripard, because drivers aren't al