Re: [PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-18 Thread Danilo Krummrich
On Wed, Jun 18, 2025 at 04:06:41PM +0200, Simona Vetter wrote: > On Tue, Jun 17, 2025 at 05:08:57PM +0200, Danilo Krummrich wrote: > > On Tue, Jun 17, 2025 at 04:25:09PM +0200, Simona Vetter wrote: > > > On Tue, Jun 17, 2025 at 04:10:40PM +0200, Danilo Krummrich wrote: > > > > On Tue, Jun 17, 2025

Re: [PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-18 Thread Simona Vetter
On Tue, Jun 17, 2025 at 05:08:57PM +0200, Danilo Krummrich wrote: > On Tue, Jun 17, 2025 at 04:25:09PM +0200, Simona Vetter wrote: > > On Tue, Jun 17, 2025 at 04:10:40PM +0200, Danilo Krummrich wrote: > > > On Tue, Jun 17, 2025 at 03:51:33PM +0200, Simona Vetter wrote: > > > > On Thu, Jun 12, 2025

Re: [PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-17 Thread Danilo Krummrich
On Tue, Jun 17, 2025 at 04:25:09PM +0200, Simona Vetter wrote: > On Tue, Jun 17, 2025 at 04:10:40PM +0200, Danilo Krummrich wrote: > > On Tue, Jun 17, 2025 at 03:51:33PM +0200, Simona Vetter wrote: > > > On Thu, Jun 12, 2025 at 04:49:54PM +0200, Philipp Stanner wrote: > > > > + * NOTE that sharing

Re: [PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-17 Thread Simona Vetter
On Tue, Jun 17, 2025 at 04:10:40PM +0200, Danilo Krummrich wrote: > On Tue, Jun 17, 2025 at 03:51:33PM +0200, Simona Vetter wrote: > > On Thu, Jun 12, 2025 at 04:49:54PM +0200, Philipp Stanner wrote: > > > + * NOTE that sharing &struct drm_sched_init_args.submit_wq with the > > > driver > > > + *

Re: [PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-17 Thread Danilo Krummrich
On Tue, Jun 17, 2025 at 03:51:33PM +0200, Simona Vetter wrote: > On Thu, Jun 12, 2025 at 04:49:54PM +0200, Philipp Stanner wrote: > > + * NOTE that sharing &struct drm_sched_init_args.submit_wq with the driver > > + * theoretically can deadlock. It must be guaranteed that submit_wq never > > has >

Re: [PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-17 Thread Simona Vetter
On Thu, Jun 12, 2025 at 04:49:54PM +0200, Philipp Stanner wrote: > struct drm_sched_init_args provides the possibility of letting the > scheduler use user-controlled workqueues, instead of the scheduler > creating its own workqueues. It's currently not documented who would > want to use that. > >

[PATCH v2] drm/sched: Clarify scenarios for separate workqueues

2025-06-12 Thread Philipp Stanner
struct drm_sched_init_args provides the possibility of letting the scheduler use user-controlled workqueues, instead of the scheduler creating its own workqueues. It's currently not documented who would want to use that. Not sharing the submit_wq between driver and scheduler has the advantage of n