Re: [PATCH v2] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-17 Thread Liviu Dudau
On Thu, Apr 17, 2025 at 11:32:47AM +0200, Boris Brezillon wrote: > Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by > panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can > have a file offset but can't be mapped anyway, because > panthor_gem_mmap() will filter them out. > > If

Re: [PATCH v2] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-17 Thread Matthew Auld
On 17/04/2025 10:32, Boris Brezillon wrote: Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can have a file offset but can't be mapped anyway, because panthor_gem_mmap() will filter them out. If we error out at mmap_offset cr

Re: [PATCH v2] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-17 Thread Boris Brezillon
On Thu, 17 Apr 2025 10:53:23 +0100 Matthew Auld wrote: > On 17/04/2025 10:32, Boris Brezillon wrote: > > Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by > > panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can > > have a file offset but can't be mapped anyway, because > > pa

Re: [PATCH v2] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-17 Thread Steven Price
On 17/04/2025 10:32, Boris Brezillon wrote: > Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by > panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can > have a file offset but can't be mapped anyway, because > panthor_gem_mmap() will filter them out. > > If we error out at mmap

Re: [PATCH v2] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-17 Thread Boris Brezillon
On Thu, 17 Apr 2025 11:32:47 +0200 Boris Brezillon wrote: > Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by > panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can > have a file offset but can't be mapped anyway, because > panthor_gem_mmap() will filter them out. > > If we e

[PATCH v2] drm/panthor: Don't create a file offset for NO_MMAP BOs

2025-04-17 Thread Boris Brezillon
Right now the DRM_PANTHOR_BO_NO_MMAP flag is ignored by panthor_ioctl_bo_mmap_offset(), meaning BOs with this flag set can have a file offset but can't be mapped anyway, because panthor_gem_mmap() will filter them out. If we error out at mmap_offset creation time, we can get rid of panthor_gem_mma