Re: [PATCH v2] drm/panel: rpi-touchscreen: Add backlight support

2018-12-21 Thread Gordon Hollingworth
Assuming this is using the firmware interface then yes it's fine. If it is using the i2c directly then it's possible to clash with the GPU driving the camera Gordon On Thu, 20 Dec 2018, 18:33 Eric Anholt, wrote: > Nicolas Saenz Julienne writes: > > > This patch exposes backlight control into

Re: [PATCH v2] drm/panel: rpi-touchscreen: Add backlight support

2018-12-21 Thread Nicolas Saenz Julienne
On Thu, 2018-12-20 at 18:36 +, Gordon Hollingworth wrote: > Assuming this is using the firmware interface then yes it's fine. If > it is using the i2c directly then it's possible to clash with the GPU > driving the camera Well we're already in such a situation without this patch, as the panel

Re: [PATCH v2] drm/panel: rpi-touchscreen: Add backlight support

2018-12-20 Thread Eric Anholt
Nicolas Saenz Julienne writes: > This patch exposes backlight control into userspace by creating a > backlight device instead of directly accessing the PWM registers. > > The backlight driver can't go on a separate file as it shares the I2C > bus & address with the panel. I remember some concern

[PATCH v2] drm/panel: rpi-touchscreen: Add backlight support

2018-12-20 Thread Nicolas Saenz Julienne
This patch exposes backlight control into userspace by creating a backlight device instead of directly accessing the PWM registers. The backlight driver can't go on a separate file as it shares the I2C bus & address with the panel. Signed-off-by: Nicolas Saenz Julienne --- v1 -> v2: - Add Kcon