Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-05-24 Thread Kees Cook
On Wed, May 23, 2018 at 5:36 PM, Ben Skeggs wrote: > On Thu, May 24, 2018 at 8:48 AM, Kees Cook wrote: >> On Thu, Apr 26, 2018 at 4:25 PM, Kees Cook wrote: >>> On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: On 14 March 2018 at 21:08, Thierry Reding wrote: > On Tue, Mar 13, 2018 at

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-05-24 Thread Kees Cook
On Thu, Apr 26, 2018 at 4:25 PM, Kees Cook wrote: > On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: >> On 14 March 2018 at 21:08, Thierry Reding wrote: >>> On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wvla, remove VLA. In this particula

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-05-23 Thread Ben Skeggs
On Thu, May 24, 2018 at 8:48 AM, Kees Cook wrote: > On Thu, Apr 26, 2018 at 4:25 PM, Kees Cook wrote: >> On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: >>> On 14 March 2018 at 21:08, Thierry Reding wrote: On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: > In pre

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-04-27 Thread Kees Cook
On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: > On 14 March 2018 at 21:08, Thierry Reding wrote: >> On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wvla, remove VLA. In this particular >>> case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-03-15 Thread Ben Skeggs
On 14 March 2018 at 21:08, Thierry Reding wrote: > On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wvla, remove VLA. In this particular >> case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local >> variable cmdline_size. Also, remove

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-03-14 Thread Thierry Reding
On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA. In this particular > case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local > variable cmdline_size. Also, remove cmdline_size as it is not > actually useful anymore. >

[PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-03-14 Thread Gustavo A. R. Silva
In preparation to enabling -Wvla, remove VLA. In this particular case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local variable cmdline_size. Also, remove cmdline_size as it is not actually useful anymore. The use of stack Variable Length Arrays needs to be avoided, as they can be a