Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-03 Thread Leonard Crestez
On Thu, 2018-08-02 at 13:06 +0200, Stefan Agner wrote: > On 02.08.2018 12:17, Philipp Zabel wrote: > > On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: > > > On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > > > > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > > > > >

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Philipp Zabel
Hi Stefan, On Wed, 2018-08-01 at 12:00 +0200, Stefan Agner wrote: [...] > > @@ -307,14 +335,15 @@ void mxsfb_plane_atomic_update(struct > > mxsfb_drm_private *mxsfb, > > drm_crtc_send_vblank_event(crtc, event); > > } > > } > > spin_unlock_irq(&crtc->dev->eve

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Stefan Agner
On 02.08.2018 12:17, Philipp Zabel wrote: > On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: >> On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: >> > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: >> > > Adding lcdif nodes to a power domain currently does work, it results

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Philipp Zabel
On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: > On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > > > Adding lcdif nodes to a power domain currently does work, it results in > > > black/corrupted screens or hangs. Whi

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Leonard Crestez
On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > Adding lcdif nodes to a power domain currently does work, it results in > black/corrupted screens or hangs. While the driver does enable runtime > pm it does not deal correctly with the block being unpowered. > > Ensure power is on when r

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Leonard Crestez
On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > > Adding lcdif nodes to a power domain currently does work, it results in > > black/corrupted screens or hangs. While the driver does enable runtime > > pm it does not deal correctl

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-01 Thread Stefan Agner
On 17.07.2018 12:48, Leonard Crestez wrote: > Adding lcdif nodes to a power domain currently does work, it results in > black/corrupted screens or hangs. While the driver does enable runtime > pm it does not deal correctly with the block being unpowered. > > Ensure power is on when required by add

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-07-31 Thread Philipp Zabel
On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > Adding lcdif nodes to a power domain currently does work, it results in > black/corrupted screens or hangs. While the driver does enable runtime > pm it does not deal correctly with the block being unpowered. > > Ensure power is on when r

[PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-07-18 Thread Leonard Crestez
Adding lcdif nodes to a power domain currently does work, it results in black/corrupted screens or hangs. While the driver does enable runtime pm it does not deal correctly with the block being unpowered. Ensure power is on when required by adding pm_runtime_get/put_sync to mxsfb_pipe_enable/disab