Re: [PATCH v2] drm/msm: remove unnecessary NULL check

2023-11-21 Thread Abhinav Kumar
On Fri, 13 Oct 2023 11:25:15 +0300, Dan Carpenter wrote: > This NULL check was required when it was added, but we shuffled the code > around and now it's not. The inconsistent NULL checking triggers a > Smatch warning: > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: >

Re: [Freedreno] [PATCH v2] drm/msm: remove unnecessary NULL check

2023-11-20 Thread Dan Carpenter
On Thu, Nov 16, 2023 at 01:05:52PM -0800, Abhinav Kumar wrote: > > > On 11/1/2023 12:23 PM, Abhinav Kumar wrote: > > > > > > On 10/13/2023 1:25 AM, Dan Carpenter wrote: > > > This NULL check was required when it was added, but we shuffled the code > > > around and now it's not.? The inconsisten

Re: [Freedreno] [PATCH v2] drm/msm: remove unnecessary NULL check

2023-11-16 Thread Abhinav Kumar
On 11/1/2023 12:23 PM, Abhinav Kumar wrote: On 10/13/2023 1:25 AM, Dan Carpenter wrote: This NULL check was required when it was added, but we shuffled the code around and now it's not.  The inconsistent NULL checking triggers a Smatch warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c

Re: [PATCH v2] drm/msm: remove unnecessary NULL check

2023-11-01 Thread Abhinav Kumar
On 10/13/2023 1:25 AM, Dan Carpenter wrote: This NULL check was required when it was added, but we shuffled the code around and now it's not. The inconsistent NULL checking triggers a Smatch warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: variable dereferenc

Re: [PATCH v2] drm/msm: remove unnecessary NULL check

2023-10-25 Thread Dmitry Baryshkov
On 13/10/2023 11:25, Dan Carpenter wrote: This NULL check was required when it was added, but we shuffled the code around and now it's not. The inconsistent NULL checking triggers a Smatch warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: variable dereferenced be

Re: [PATCH v2] drm/msm: remove unnecessary NULL check

2023-10-13 Thread Uwe Kleine-König
On Fri, Oct 13, 2023 at 11:25:15AM +0300, Dan Carpenter wrote: > This NULL check was required when it was added, but we shuffled the code > around and now it's not. The inconsistent NULL checking triggers a > Smatch warning: > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: >

[PATCH v2] drm/msm: remove unnecessary NULL check

2023-10-13 Thread Dan Carpenter
This NULL check was required when it was added, but we shuffled the code around and now it's not. The inconsistent NULL checking triggers a Smatch warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: variable dereferenced before check 'mdp5_kms' (see line 782) Fixes: 1