Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-08 Thread Dmitry Baryshkov
On Tue, 9 Jul 2024 at 00:27, Konrad Dybcio wrote: > > On 8.07.2024 2:49 PM, Dmitry Baryshkov wrote: > > On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez wrote: > >> > >> On 05/07/2024 16:34, Dmitry Baryshkov wrote: > > [...] > > >>> I'm not going to check the math, but it looks pretty close to what we

Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-08 Thread Konrad Dybcio
On 8.07.2024 2:49 PM, Dmitry Baryshkov wrote: > On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez wrote: >> >> On 05/07/2024 16:34, Dmitry Baryshkov wrote: [...] >>> I'm not going to check the math, but it looks pretty close to what we >>> have for msm8996. >> >> What is the consequence of this? > > T

Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-08 Thread Dmitry Baryshkov
On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez wrote: > > On 05/07/2024 16:34, Dmitry Baryshkov wrote: > > > On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote: > > > >> From: Arnaud Vrac > >> > >> Ported from the downstream driver. > > > > Please write some sensible commit message. > > Here

Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-08 Thread Marc Gonzalez
On 05/07/2024 16:34, Dmitry Baryshkov wrote: > On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote: > >> From: Arnaud Vrac >> >> Ported from the downstream driver. > > Please write some sensible commit message. Here's an attempt at expanding the commit message: """ This code adds suppo

Re: [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-05 Thread Dmitry Baryshkov
On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote: > From: Arnaud Vrac > > Ported from the downstream driver. Please write some sensible commit message. > > Signed-off-by: Arnaud Vrac > Signed-off-by: Marc Gonzalez > --- > drivers/gpu/drm/msm/Makefile | 1 + >

[PATCH v2] drm/msm: add msm8998 hdmi phy/pll support

2024-07-04 Thread Marc Gonzalez
From: Arnaud Vrac Ported from the downstream driver. Signed-off-by: Arnaud Vrac Signed-off-by: Marc Gonzalez --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/hdmi/hdmi.c| 1 + drivers/gpu/drm/msm/hdmi/hdmi.h| 8 + drivers/gpu/