Re: [PATCH v2] drm/msm/a6xx+: Don't let IB_SIZE overflow

2025-03-14 Thread Akhil P Oommen
On 3/15/2025 12:04 AM, Rob Clark wrote: > From: Rob Clark > > IB_SIZE is only b0..b19. Starting with a6xx gen3, additional fields > were added above the IB_SIZE. Accidentially setting them can cause > badness. Fix this by properly defining the CP_INDIRECT_BUFFER packet > and using the generate

Re: [PATCH v2] drm/msm/a6xx+: Don't let IB_SIZE overflow

2025-03-14 Thread Rob Clark
On Fri, Mar 14, 2025 at 1:07 PM Akhil P Oommen wrote: > > On 3/15/2025 12:04 AM, Rob Clark wrote: > > From: Rob Clark > > > > IB_SIZE is only b0..b19. Starting with a6xx gen3, additional fields > > were added above the IB_SIZE. Accidentially setting them can cause > > badness. Fix this by prop

[PATCH v2] drm/msm/a6xx+: Don't let IB_SIZE overflow

2025-03-14 Thread Rob Clark
From: Rob Clark IB_SIZE is only b0..b19. Starting with a6xx gen3, additional fields were added above the IB_SIZE. Accidentially setting them can cause badness. Fix this by properly defining the CP_INDIRECT_BUFFER packet and using the generated builder macro to ensure unintended bits are not se