Re: [PATCH v2] drm/mediatek: fix a timeout loop

2017-05-21 Thread CK Hu
Hi, Dan: Sorry for the late reply. I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1. Regards, CK On Fri, 2017-04-21 at 13:51 +0300, Dan Carpenter wrote: > This code causes a static checker warning because it treats "i == 0" as > a timeout but, because it's a post-op, the loop act

Re: [PATCH v2] drm/mediatek: fix a timeout loop

2017-04-21 Thread Philipp Zabel
On Fri, 2017-04-21 at 13:51 +0300, Dan Carpenter wrote: > This code causes a static checker warning because it treats "i == 0" as > a timeout but, because it's a post-op, the loop actually ends with "i" > set to -1. Philipp Zabel points out that it would be cleaner to use > readl_poll_timeout() in

[PATCH v2] drm/mediatek: fix a timeout loop

2017-04-21 Thread Dan Carpenter
This code causes a static checker warning because it treats "i == 0" as a timeout but, because it's a post-op, the loop actually ends with "i" set to -1. Philipp Zabel points out that it would be cleaner to use readl_poll_timeout() instead. Fixes: 21898816831f ("drm/mediatek: add dsi transfer fun