Re: [Intel-gfx] [PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-05-04 Thread Tvrtko Ursulin
On 20/04/2022 10:57, Karol Herbst wrote: i915_vma_reopen checked if the vma is closed before without taking the lock. So multiple threads could attempt removing the vma. Instead the lock needs to be taken before actually checking. v2: move struct declaration Cc: Chris Wilson Cc: intel-...@l

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-05-03 Thread Tvrtko Ursulin
On 20/04/2022 10:57, Karol Herbst wrote: i915_vma_reopen checked if the vma is closed before without taking the lock. So multiple threads could attempt removing the vma. Instead the lock needs to be taken before actually checking. v2: move struct declaration Fix looks correct to me. In whic

Re: [PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-05-02 Thread Karol Herbst
friendly ping. I am not even myself completely convinced that this is the correct patch and it might just workaround some issues, but list_debug.c does check if a list was already deleted and throws an error if it was and this patch indeed fixes this one issue as multiple threads could enter __i91

[PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-04-20 Thread Karol Herbst
i915_vma_reopen checked if the vma is closed before without taking the lock. So multiple threads could attempt removing the vma. Instead the lock needs to be taken before actually checking. v2: move struct declaration Cc: Chris Wilson Cc: intel-...@lists.freedesktop.org Cc: dri-devel@lists.free