Re: [PATCH v2] drm/gem: fix mmap vma size calculations

2013-08-01 Thread Sedat Dilek
On Wed, Jul 31, 2013 at 6:46 PM, David Herrmann wrote: > Hi > > On Tue, Jul 30, 2013 at 9:52 AM, Sedat Dilek wrote: >> On Tue, Jul 30, 2013 at 9:41 AM, Sedat Dilek wrote: >>> On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wro

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-31 Thread Sedat Dilek
On Wed, Jul 31, 2013 at 6:46 PM, David Herrmann wrote: > Hi > > On Tue, Jul 30, 2013 at 9:52 AM, Sedat Dilek wrote: >> On Tue, Jul 30, 2013 at 9:41 AM, Sedat Dilek >> wrote: >>> On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrman

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-31 Thread David Herrmann
Hi On Tue, Jul 30, 2013 at 9:52 AM, Sedat Dilek wrote: > On Tue, Jul 30, 2013 at 9:41 AM, Sedat Dilek wrote: >> On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: >>> On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: The VMA manager is page-size based so drm_vma_node_size

Re: [PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-31 Thread David Herrmann
Hi On Tue, Jul 30, 2013 at 9:52 AM, Sedat Dilek wrote: > On Tue, Jul 30, 2013 at 9:41 AM, Sedat Dilek wrote: >> On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: >>> On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: The VMA manager is page-size based so drm_vma_node_size

Re: [PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-30 Thread Sedat Dilek
On Tue, Jul 30, 2013 at 9:41 AM, Sedat Dilek wrote: > On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: >> On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: >>> The VMA manager is page-size based so drm_vma_node_size() returns the size >>> in pages. However, drm_gem_mmap_obj()

Re: [PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-30 Thread Sedat Dilek
On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: > On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: >> The VMA manager is page-size based so drm_vma_node_size() returns the size >> in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply >> PAGE_SHIFT so we no l

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-30 Thread Sedat Dilek
On Tue, Jul 30, 2013 at 9:41 AM, Sedat Dilek wrote: > On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: >> On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: >>> The VMA manager is page-size based so drm_vma_node_size() returns the size >>> in pages. However, drm_gem_mmap_obj()

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-30 Thread Sedat Dilek
On Fri, Jul 26, 2013 at 10:15 PM, Daniel Vetter wrote: > On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: >> The VMA manager is page-size based so drm_vma_node_size() returns the size >> in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply >> PAGE_SHIFT so we no l

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: > The VMA manager is page-size based so drm_vma_node_size() returns the size > in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply > PAGE_SHIFT so we no longer get EINVAL during mmaps due to too small > buffers. >

Re: [PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2013 at 12:09:32PM +0200, David Herrmann wrote: > The VMA manager is page-size based so drm_vma_node_size() returns the size > in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply > PAGE_SHIFT so we no longer get EINVAL during mmaps due to too small > buffers. >

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-26 Thread David Herrmann
The VMA manager is page-size based so drm_vma_node_size() returns the size in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply PAGE_SHIFT so we no longer get EINVAL during mmaps due to too small buffers. This bug was introduced in commit: 0de23977cfeb5b357ec884ba15417ae118ff9

[PATCH v2] drm/gem: fix mmap vma size calculations

2013-07-26 Thread David Herrmann
The VMA manager is page-size based so drm_vma_node_size() returns the size in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply PAGE_SHIFT so we no longer get EINVAL during mmaps due to too small buffers. This bug was introduced in commit: 0de23977cfeb5b357ec884ba15417ae118ff9