Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-24 Thread Marian Mihailescu
This patch works on my odroid xu4 too, on 5.0.3 kernel. Thanks! -Marian > On 19 Mar 2019, at 11:35 pm, Andrzej Hajda wrote: > > MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 > to update internal state (shadow registers). > Apparently the driver implements it incorrect

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Inki Dae
Hi Marek, 19. 3. 21. 오후 5:32에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2019-03-21 09:20, Inki Dae wrote: >> 19. 3. 19. 오후 10:05에 Andrzej Hajda 이(가) 쓴 글: >>> MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 >>> to update internal state (shadow registers). >>> Apparently

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Marek Szyprowski
Hi Inki, On 2019-03-21 09:20, Inki Dae wrote: > 19. 3. 19. 오후 10:05에 Andrzej Hajda 이(가) 쓴 글: >> MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 >> to update internal state (shadow registers). >> Apparently the driver implements it incorrectly. The rule should be >> as foll

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Inki Dae
19. 3. 19. 오후 10:05에 Andrzej Hajda 이(가) 쓴 글: > MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 > to update internal state (shadow registers). > Apparently the driver implements it incorrectly. The rule should be > as follows: > - do not request updating registers until pr

[PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-19 Thread Andrzej Hajda
MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 to update internal state (shadow registers). Apparently the driver implements it incorrectly. The rule should be as follows: - do not request updating registers until previous request was finished, ie. MXR_CFG_LAYER_UPDATE_C