Re: [PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-18 Thread Navid Emamdoost
Hi Lucas, On Wed, Jun 17, 2020 at 4:53 AM Lucas Stach wrote: > > Hi Navid, > > Am Montag, den 15.06.2020, 01:12 -0500 schrieb Navid Emamdoost: > > in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, > > and etnaviv_gpu_init the call to pm_runtime_get_sync increments the > > cou

Re: [PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-17 Thread Lucas Stach
Hi Navid, Am Montag, den 15.06.2020, 01:12 -0500 schrieb Navid Emamdoost: > in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, > and etnaviv_gpu_init the call to pm_runtime_get_sync increments the > counter even in case of failure, leading to incorrect ref count. > In case of fa

Re: [PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-16 Thread Markus Elfring
… > In case of failure, decrement the ref count before returning. Can it be nicer to use the term “reference count” here? Will the tag “Fixes” become helpful for the commit message? … > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c … > @@ -1326,6 +1331,7 @@ struct dma_fence *etnaviv_gpu_submit(s

[PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-15 Thread Navid Emamdoost
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, and etnaviv_gpu_init the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost -