Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-06-06 Thread Ville Syrjälä
> >> https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/drm-client-Detect-when-ACPI-lid-is-closed-during-initialization/20240529-050440 > >> base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > >> patch link: > >> https://lore.kern

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-06-06 Thread Jani Nikula
20240529-050440 >> base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next >> patch link: >> https://lore.kernel.org/r/20240528210319.1242-1-mario.limonciello%40amd.com >> patch subject: [PATCH v2] drm/client: Detect when ACPI lid is closed during >> ini

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-06-05 Thread Chris Bainbridge
ink: > https://lore.kernel.org/r/20240528210319.1242-1-mario.limonciello%40amd.com > patch subject: [PATCH v2] drm/client: Detect when ACPI lid is closed during > initialization > config: i386-randconfig-053-20240604 > (https://download.01.org/0day-ci/archive/20240604/202406040928.eu1gr

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-06-03 Thread kernel test robot
ent-Detect-when-ACPI-lid-is-closed-during-initialization/20240529-050440 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20240528210319.1242-1-mario.limonciello%40amd.com patch subject: [PATCH v2] drm/client: Detect when ACPI lid is clo

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-30 Thread Dmitry Torokhov
On Thu, May 30, 2024 at 11:07:53AM +0300, Dmitry Baryshkov wrote: > On Thu, 30 May 2024 at 07:41, Limonciello, Mario > wrote: > > > > > > >> Also a direct acpi_lid_open() call seems a bit iffy. But I guess if > > >> someone needs this to work on non-ACPI system they get to figure out > > >> how to

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-30 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 07:41, Limonciello, Mario wrote: > > > >> Also a direct acpi_lid_open() call seems a bit iffy. But I guess if > >> someone needs this to work on non-ACPI system they get to figure out > >> how to abstract it better. acpi_lid_open() does seem to return != 0 > >> when ACPI is

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Limonciello, Mario
Also a direct acpi_lid_open() call seems a bit iffy. But I guess if someone needs this to work on non-ACPI system they get to figure out how to abstract it better. acpi_lid_open() does seem to return != 0 when ACPI is not supported, so at least it would err on the side of enabling everything.

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 06:39:21PM +0300, Ville Syrjälä wrote: > On Wed, May 29, 2024 at 09:45:55AM -0500, Mario Limonciello wrote: > > On 5/29/2024 09:14, Ville Syrjälä wrote: > > > On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > > >> If the lid on a laptop is closed when eDP

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
If you don't hook into some lid notify event how is one supposed to get the display back to life after opening the lid? I guess in my mind it's a tangential to the "initial modeset". The DRM master can issue a modeset to enable the combination as desired. This code is run whenever there's

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Ville Syrjälä
On Wed, May 29, 2024 at 09:45:55AM -0500, Mario Limonciello wrote: > On 5/29/2024 09:14, Ville Syrjälä wrote: > > On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > >> If the lid on a laptop is closed when eDP connectors are populated > >> then it remains enabled when the initial

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 09:14, Ville Syrjälä wrote: On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the initial framebuffer configuration is built. When creating the initial framebuffer confi

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 08:55, Alex Deucher wrote: On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: On Wed, 29 May 2024, Alex Deucher wrote: On Tue, May 28, 2024 at 5:03 PM Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Ville Syrjälä
On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > If the lid on a laptop is closed when eDP connectors are populated > then it remains enabled when the initial framebuffer configuration > is built. > > When creating the initial framebuffer configuration detect the ACPI > lid sta

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: > > On Wed, 29 May 2024, Alex Deucher wrote: > > On Tue, May 28, 2024 at 5:03 PM Mario Limonciello > > wrote: > >> > >> If the lid on a laptop is closed when eDP connectors are populated > >> then it remains enabled when the initial framebuffer

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Jani Nikula
On Wed, 29 May 2024, Alex Deucher wrote: > On Tue, May 28, 2024 at 5:03 PM Mario Limonciello > wrote: >> >> If the lid on a laptop is closed when eDP connectors are populated >> then it remains enabled when the initial framebuffer configuration >> is built. >> >> When creating the initial framebu

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
On Tue, May 28, 2024 at 5:03 PM Mario Limonciello wrote: > > If the lid on a laptop is closed when eDP connectors are populated > then it remains enabled when the initial framebuffer configuration > is built. > > When creating the initial framebuffer configuration detect the ACPI > lid status and

[PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-28 Thread Mario Limonciello
If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the initial framebuffer configuration is built. When creating the initial framebuffer configuration detect the ACPI lid status and if it's closed disable any eDP connectors. Reported-by: Chris Bainbrid